git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 08/12] builtin/unpack-file: convert to struct object_id

From
brian m. carlson <sandals@crustytoothpaste.net>
Date
Jul 3, 2017, 18:55 UTC
Message-ID
<20170703185533.51530-9-sandals@crustytoothpaste.net>
In-Reply-To
<20170703185533.51530-1-sandals@crustytoothpaste.net>
Signed-off-by: brian m. carlson <sandals@crustytoothpaste.net>
---
 builtin/unpack-file.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/builtin/unpack-file.c b/builtin/unpack-file.c
index 73f133419..281ca1db6 100644
--- a/builtin/unpack-file.c
+++ b/builtin/unpack-file.c
@@ -1,7 +1,7 @@
 #include "builtin.h"
 #include "config.h"
 
-static char *create_temp_file(unsigned char *sha1)
+static char *create_temp_file(struct object_id *oid)
 {
 	static char path[50];
 	void *buf;
@@ -9,9 +9,9 @@ static char *create_temp_file(unsigned char *sha1)
 	unsigned long size;
 	int fd;
 
-	buf = read_sha1_file(sha1, &type, &size);
+	buf = read_sha1_file(oid->hash, &type, &size);
 	if (!buf || type != OBJ_BLOB)
-		die("unable to read blob object %s", sha1_to_hex(sha1));
+		die("unable to read blob object %s", oid_to_hex(oid));
 
 	xsnprintf(path, sizeof(path), ".merge_file_XXXXXX");
 	fd = xmkstemp(path);
@@ -23,15 +23,15 @@ static char *create_temp_file(unsigned char *sha1)
 
 int cmd_unpack_file(int argc, const char **argv, const char *prefix)
 {
-	unsigned char sha1[20];
+	struct object_id oid;
 
 	if (argc != 2 || !strcmp(argv[1], "-h"))
 		usage("git unpack-file <sha1>");
-	if (get_sha1(argv[1], sha1))
+	if (get_oid(argv[1], &oid))
 		die("Not a valid object name %s", argv[1]);
 
 	git_config(git_default_config, NULL);
 
-	puts(create_temp_file(sha1));
+	puts(create_temp_file(&oid));
 	return 0;
 }
Previous: brian m. carlsonNext: brian m. carlson
Message 7 of 20 in “object_id part 9”
  1. 00/12 object_id part 9brian m. carlson, Jul 3, 2017
  2. 01/12 builtin/fsck: convert remaining caller of get_sha1 to object_idbrian m. carlson, Jul 3, 2017
  3. 07/12 bisect: convert bisect_checkout to struct object_idbrian m. carlson, Jul 3, 2017
  4. 05/12 sequencer: convert to struct object_idbrian m. carlson, Jul 3, 2017
  5. 04/12 remote: convert struct push_cas to struct object_idbrian m. carlson, Jul 3, 2017
  6. 02/12 builtin/merge-tree: convert remaining caller of get_sha1 to object_idbrian m. carlson, Jul 3, 2017
  7. 08/12 builtin/unpack-file: convert to struct object_idbrian m. carlson, Jul 3, 2017
  8. 10/12 Convert remaining callers of get_sha1 to get_oid.brian m. carlson, Jul 3, 2017
  9. 06/12 builtin/update_ref: convert to struct object_idbrian m. carlson, Jul 3, 2017
  10. Ævar Arnfjörð BjarmasonJul 3, 2017
  11. brian m. carlsonJul 4, 2017
  12. 03/12 submodule: convert submodule config lookup to use object_idbrian m. carlson, Jul 3, 2017
  13. 09/12 builtin/verify-tag: convert to struct object_idbrian m. carlson, Jul 3, 2017
  14. 12/12 sha1_name: convert GET_SHA1* flags to GET_OID*brian m. carlson, Jul 3, 2017
  15. 11/12 sha1_name: convert get_sha1* to get_oid*brian m. carlson, Jul 3, 2017
  16. Stefan BellerJul 5, 2017
  17. Junio C HamanoJul 5, 2017
  18. brian m. carlsonJul 7, 2017
  19. Junio C HamanoJul 5, 2017
  20. Stefan BellerJul 5, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.