Re: [PATCH v2] user-manual: mention git gui citool (commit, amend)

From: David Kastrup <dak@gnu.org>
Date: Aug 5, 2007, 15:03 UTC
Message-ID: <85wswa6n1o.fsf@lola.goethe.zz>
In-Reply-To: <17AA7EBE-B755-4F26-9C7E-AF6D762811F2@zib.de>

Steffen Prohaska <prohaska@zib.de> writes:

Show 18 quoted lines

> On Aug 5, 2007, at 3:58 PM, Johannes Schindelin wrote:
>
>> Hi,
>>
>> On Sun, 5 Aug 2007, Steffen Prohaska wrote:
>>
>>> git gui is especially useful because it allows to select diff hunks.
>>
>> You should give a _big_ _fat_ _red_ warning there.
>>
>> If you selectively commit diff hunks, you _never_ tested what you
>> committed.
>>
>> That is the reason we're not advertising git add -i more actively.
>
> Hmm... If you do 'git cherry-pick' or 'git rebase' you also did
> not test what you committed. Should we advertise them less
> actively as well?

Selectively committing diff hunks also means that a subsequent rebase -i or git-cherry will have to reconsider the same commit as it has only been incompletely applied.

So it can mean more work later. Also one would in general have to edit the commit message (if it describes everything that has been done).

There are simply consequences for the workflow if you do things right. Whether they are worth a "big fat red warning" is one question, but mentioning them is probably not amiss.

-- 
David Kastrup, Kriemhildstr. 15, 44793 Bochum