Re: [PATCH v2] user-manual: mention git gui citool (commit, amend)

From: Steffen Prohaska <prohaska@zib.de>
Date: Aug 5, 2007, 14:17 UTC
Message-ID: <17AA7EBE-B755-4F26-9C7E-AF6D762811F2@zib.de>
In-Reply-To: <Pine.LNX.4.64.0708051457110.14781@racer.site>

On Aug 5, 2007, at 3:58 PM, Johannes Schindelin wrote:

Show 12 quoted lines

> Hi,
>
> On Sun, 5 Aug 2007, Steffen Prohaska wrote:
>
>> git gui is especially useful because it allows to select diff hunks.
>
> You should give a _big_ _fat_ _red_ warning there.
>
> If you selectively commit diff hunks, you _never_ tested what you
> committed.
>
> That is the reason we're not advertising git add -i more actively.

Hmm... If you do 'git cherry-pick' or 'git rebase' you also did not test what you committed. Should we advertise them less actively as well?

But I see your point. Selecting diff hunks tends to be more fine grained than cherry-picking. But this depends on the details of what you're doing. I don't think a general warning is appropriate.

	Steffen