Re: [PATCH] Allow shell scripts to run with non-Bash /bin/sh

From: David Kastrup <dak@gnu.org>
Date: Sep 23, 2007, 19:33 UTC
Message-ID: <853ax5mb1j.fsf@lola.goethe.zz>
In-Reply-To: <7vy7excho4.fsf@gitster.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com> writes:

Show 10 quoted lines

> David Kastrup <dak@gnu.org> writes:
>
>> Independent of that: would you mind a patch replacing that idiom with
>>
>> while : do case xxx) break; esac
>>
>> instead?  I find breaking out of the condition rather than the body
>> awkward,...
>
> I do not have any problem with your approach at all.

Too bad sh does... I need to write

while :; do case xxx) break; esac

instead which is slightly uglier concerning visual aesthetics.

> But on one condition, however.  If it is done correctly with
> double semi-colons before "esac" ;-)

My feeling about this is that double semi-colons before "esac" are redundant and similarly ugly as ";" before "end" in Pascal. However, looking at the existing git scripts it would seem that the redundant style is ubiquitous anyway, so it would be inconsistent to do this differently just within the idiom.

-- 
David Kastrup, Kriemhildstr. 15, 44793 Bochum