Re: [PATCH] Allow shell scripts to run with non-Bash /bin/sh
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Sep 23, 2007, 19:20 UTC
- Message-ID
- <7vy7excho4.fsf@gitster.siamese.dyndns.org>
- In-Reply-To
- <85ir61rc3r.fsf@lola.goethe.zz>
David Kastrup <dak@gnu.org> writes:
Show 6 quoted lines
> Independent of that: would you mind a patch replacing that idiom with > > while : do case xxx) break; esac > > instead? I find breaking out of the condition rather than the body > awkward,...
I do not have any problem with your approach at all.
While I personally do not think it improves readability much, I do not think it hurts either. And it is a valid workaround for FBSD issue, so why not.
But on one condition, however. If it is done correctly with double semi-colons before "esac" ;-)
Thanks.