Re: [PATCH] Allow shell scripts to run with non-Bash /bin/sh

From: Adam Flott <adam@npjh.com>
Date: Sep 22, 2007, 21:37 UTC
Message-ID: <20070922162750.Y1876@localhost>
In-Reply-To: <7vhclngpgd.fsf@gitster.siamese.dyndns.org>

On Fri, 21 Sep 2007, Junio C Hamano wrote:

Show 5 quoted lines

> I vaguely recall somebody else had exactly this issue and he
> concluded that the shell was busted.  I do not recall the
> details of the story but interestingly, if he did something that
> accesses "$#" before the problematic "while case $# in ..." the
> shell behaved for him in his experiments.

That is what I did notice, just accessing $# fixed later uses of it.

Show 5 quoted lines

> Also by my comment about "/bin/sh and bash not being the only
> shells available on FreeBSD", I did not mean that you should
> change your /bin/sh.  You can build git with SHELL_PATH make
> varilable pointing at a non-broken shell, which does not have to
> be installed as /bin/sh.

If one's installing from the ports tree, then the port should depend on a non-broken shell and set SHELL_PATH. And as for installing by hand, just print out a warning that SHELL_PATH points to a broken shell and be done with it. This is a FreeBSD bug, not a git one.

I had been meaning to write up a bug about this using a small test case, but I couldn't reproduce it.

Adam