Re: [PATCH] Builtin-commit: show on which branch a commit was added
- From
Wincent Colaiuta <win@wincent.com>
- Date
- Sep 30, 2008, 06:37 UTC
- Message-ID
- <836C204F-F5AF-4887-99C9-04E70FEEB998@wincent.com>
- In-Reply-To
- <48E1C39F.4070906@op5.se>
El 30/9/2008, a las 8:13, Andreas Ericsson escribió:
Show 12 quoted lines
> Jeff King wrote: >> On Mon, Sep 29, 2008 at 10:09:17PM +0200, Pieter de Bie wrote: >>> How about something like >>> >>> Created commit abcd1234 on widget -- "subwidget: one line summary" >> I think that is probably just trading one visual problem for another. >> That is, there are other people will have the same problem with "--" >> that I had with ": ". > > Created 6207abc (subwidget: one quite long line of sum...) on <branch> > > "commit" is just noise.
Excellent point on the noise. Independently of whether the branch info gets added the word "commit" should probably be dropped.
As far as long-line-wrapping goes, I don't really think this is a problem for Git to solve (by truncation or any other means); it's more of a user behaviour thing where one would hope that users would get into the habit of using concise subject lines and branch names.
Cheers, Wincent