git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC/PATCH] git.spec: fix changelog dates

From
Remi Galan Alfonso <remi.galan-alfonso@ensimag.grenoble-inp.fr>
Date
Apr 5, 2016, 12:28 UTC
Message-ID
<833355852.2977267.1459859316816.JavaMail.zimbra@ensimag.grenoble-inp.fr>
In-Reply-To
<6ef7d9d87f0c14147267c44e8b382f988936875b.1459858117.git.git@drmicha.warpmail.net>
Michael J Gruber <git@drmicha.warpmail.net> wrote:
Show 35 quoted lines
> A few changelog entries have inconsistent dates, which rpmlint reports
> as errors.
> 
> Fix them based on these assumptions:
> - It's easier to mistype a number than a weekday abbreviation.
> - changelog date must be before git commit date
> - The mistyped date is just a few days off.
> 
> Signed-off-by: Michael J Gruber <git@drmicha.warpmail.net>
> ---
> I dunno if this is worthwhile, but rpmlint is the first thing we tell
> packagers and reviewers to check.
> 
>  git.spec.in | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/git.spec.in b/git.spec.in
> index bfd1cfb..eb581a3 100644
> --- a/git.spec.in
> +++ b/git.spec.in
> @@ -229,7 +229,7 @@ rm -rf $RPM_BUILD_ROOT
>  * Sat Jan 30 2010 Junio C Hamano <gitster@pobox.com>
>  - We don't ship Python bits until a real foreign scm interface comes.
>  
> -* Mon Feb 04 2009 David J. Mellor <dmellor@whistlingcat.com>
> +* Mon Feb 02 2009 David J. Mellor <dmellor@whistlingcat.com>
>  - fixed broken git help -w after renaming the git-core package to git.
>  
>  * Fri Sep 12 2008 Quy Tonthat <qtonthat@gmail.com>
> @@ -262,7 +262,7 @@ rm -rf $RPM_BUILD_ROOT
>  * Thu Jun 21 2007 Shawn O. Pearce <spearce@spearce.org>
>  - Added documentation files for git-gui
>  
> -* Tue May 13 2007 Quy Tonthat <qtonthat@gmail.com>
> +* Sun May 13 2007 Quy Tonthat <qtonthat@gmail.com>

It is inconsistent with what you said in the commit message ("It's easier to mistype a number than a weekday abbreviation.").

Following that logic, it should be:
	* Tue May 15 2007 Quy Tonthat <qtonthat@gmail.com>

(or 08, I didn't check the condition "changelog date must be before git commit date")

Thanks, Rémi

Previous: Michael J GruberNext: Michael J Gruber
Message 2 of 4 in “git.spec: fix changelog dates”
  1. git.spec: fix changelog datesMichael J Gruber, Apr 5, 2016
  2. Remi Galan AlfonsoApr 5, 2016
  3. Michael J GruberApr 5, 2016
  4. Remi Galan AlfonsoApr 5, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.