threads / rfc / 41932

RFC patchgit.spec: fix changelog dates

Subject: [RFC/PATCH] git.spec: fix changelog dates

## tl;dr

4 messages between Apr 5, 2016 and Apr 5, 2016. Diffs are folded; open one to read it.

replies: 3people: 2as markdown or json

Michael J Gruber· Apr 5, 2016, 12:09 UTC · lore

A few changelog entries have inconsistent dates, which rpmlint reports as errors.

Fix them based on these assumptions:
- It's easier to mistype a number than a weekday abbreviation.
- changelog date must be before git commit date
- The mistyped date is just a few days off.

Signed-off-by: Michael J Gruber <git@drmicha.warpmail.net>
---
I dunno if this is worthwhile, but rpmlint is the first thing we tell
packagers and reviewers to check.

 git.spec.in | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Show changes to git.spec.in +4 −4

diff --git a/git.spec.in b/git.spec.in
index bfd1cfb..eb581a3 100644
--- a/git.spec.in
+++ b/git.spec.in
@@ -229,7 +229,7 @@ rm -rf $RPM_BUILD_ROOT
 * Sat Jan 30 2010 Junio C Hamano <gitster@pobox.com>
 - We don't ship Python bits until a real foreign scm interface comes.
 
-* Mon Feb 04 2009 David J. Mellor <dmellor@whistlingcat.com>
+* Mon Feb 02 2009 David J. Mellor <dmellor@whistlingcat.com>
 - fixed broken git help -w after renaming the git-core package to git.
 
 * Fri Sep 12 2008 Quy Tonthat <qtonthat@gmail.com>
@@ -262,7 +262,7 @@ rm -rf $RPM_BUILD_ROOT
 * Thu Jun 21 2007 Shawn O. Pearce <spearce@spearce.org>
 - Added documentation files for git-gui
 
-* Tue May 13 2007 Quy Tonthat <qtonthat@gmail.com>
+* Sun May 13 2007 Quy Tonthat <qtonthat@gmail.com>
 - Added lib files for git-gui
 - Added Documentation/technical (As needed by Git Users Manual)
 
@@ -272,7 +272,7 @@ rm -rf $RPM_BUILD_ROOT
 * Tue Mar 27 2007 Eygene Ryabinkin <rea-git@codelabs.ru>
 - Added the git-p4 package: Perforce import stuff.
 
-* Mon Feb 13 2007 Nicolas Pitre <nico@fluxnic.net>
+* Mon Feb 12 2007 Nicolas Pitre <nico@fluxnic.net>
 - Update core package description (Git isn't as stupid as it used to be)
 
 * Mon Feb 12 2007 Junio C Hamano <junkio@cox.net>
@@ -326,5 +326,5 @@ rm -rf $RPM_BUILD_ROOT
 * Thu Jul 14 2005 Eric Biederman <ebiederm@xmission.com>
 - Add the man pages, and the --without docs build option
 
-* Wed Jul 7 2005 Chris Wright <chris@osdl.org>
+* Wed Jul 6 2005 Chris Wright <chris@osdl.org>
 - initial git spec file

-- 
2.8.1.120.g4a400c2

Remi Galan Alfonso· Apr 5, 2016, 12:28 UTC · re: Michael J Gruber · lore

Re: [RFC/PATCH] git.spec: fix changelog dates

Michael J Gruber <git@drmicha.warpmail.net> wrote:

Show 35 quoted lines

> A few changelog entries have inconsistent dates, which rpmlint reports
> as errors.
> 
> Fix them based on these assumptions:
> - It's easier to mistype a number than a weekday abbreviation.
> - changelog date must be before git commit date
> - The mistyped date is just a few days off.
> 
> Signed-off-by: Michael J Gruber <git@drmicha.warpmail.net>
> ---
> I dunno if this is worthwhile, but rpmlint is the first thing we tell
> packagers and reviewers to check.
> 
>  git.spec.in | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/git.spec.in b/git.spec.in
> index bfd1cfb..eb581a3 100644
> --- a/git.spec.in
> +++ b/git.spec.in
> @@ -229,7 +229,7 @@ rm -rf $RPM_BUILD_ROOT
>  * Sat Jan 30 2010 Junio C Hamano <gitster@pobox.com>
>  - We don't ship Python bits until a real foreign scm interface comes.
>  
> -* Mon Feb 04 2009 David J. Mellor <dmellor@whistlingcat.com>
> +* Mon Feb 02 2009 David J. Mellor <dmellor@whistlingcat.com>
>  - fixed broken git help -w after renaming the git-core package to git.
>  
>  * Fri Sep 12 2008 Quy Tonthat <qtonthat@gmail.com>
> @@ -262,7 +262,7 @@ rm -rf $RPM_BUILD_ROOT
>  * Thu Jun 21 2007 Shawn O. Pearce <spearce@spearce.org>
>  - Added documentation files for git-gui
>  
> -* Tue May 13 2007 Quy Tonthat <qtonthat@gmail.com>
> +* Sun May 13 2007 Quy Tonthat <qtonthat@gmail.com>

It is inconsistent with what you said in the commit message ("It's easier to mistype a number than a weekday abbreviation.").

Following that logic, it should be:
	* Tue May 15 2007 Quy Tonthat <qtonthat@gmail.com>

(or 08, I didn't check the condition "changelog date must be before git commit date")

Thanks, Rémi

Michael J Gruber· Apr 5, 2016, 13:41 UTC · re: Remi Galan Alfonso · lore

Re: [RFC/PATCH] git.spec: fix changelog dates

Remi Galan Alfonso venit, vidit, dixit 05.04.2016 14:28:

Show 45 quoted lines

> Michael J Gruber <git@drmicha.warpmail.net> wrote:
>> A few changelog entries have inconsistent dates, which rpmlint reports
>> as errors.
>>
>> Fix them based on these assumptions:
>> - It's easier to mistype a number than a weekday abbreviation.
>> - changelog date must be before git commit date
>> - The mistyped date is just a few days off.
>>
>> Signed-off-by: Michael J Gruber <git@drmicha.warpmail.net>
>> ---
>> I dunno if this is worthwhile, but rpmlint is the first thing we tell
>> packagers and reviewers to check.
>>
>>  git.spec.in | 8 ++++----
>>  1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/git.spec.in b/git.spec.in
>> index bfd1cfb..eb581a3 100644
>> --- a/git.spec.in
>> +++ b/git.spec.in
>> @@ -229,7 +229,7 @@ rm -rf $RPM_BUILD_ROOT
>>  * Sat Jan 30 2010 Junio C Hamano <gitster@pobox.com>
>>  - We don't ship Python bits until a real foreign scm interface comes.
>>  
>> -* Mon Feb 04 2009 David J. Mellor <dmellor@whistlingcat.com>
>> +* Mon Feb 02 2009 David J. Mellor <dmellor@whistlingcat.com>
>>  - fixed broken git help -w after renaming the git-core package to git.
>>  
>>  * Fri Sep 12 2008 Quy Tonthat <qtonthat@gmail.com>
>> @@ -262,7 +262,7 @@ rm -rf $RPM_BUILD_ROOT
>>  * Thu Jun 21 2007 Shawn O. Pearce <spearce@spearce.org>
>>  - Added documentation files for git-gui
>>  
>> -* Tue May 13 2007 Quy Tonthat <qtonthat@gmail.com>
>> +* Sun May 13 2007 Quy Tonthat <qtonthat@gmail.com>
> 
> It is inconsistent with what you said in the commit message ("It's
> easier to mistype a number than a weekday abbreviation.").
> 
> Following that logic, it should be:
> 	* Tue May 15 2007 Quy Tonthat <qtonthat@gmail.com>
> 
> (or 08, I didn't check the condition "changelog date must be before
> git commit date")

I did.

The thing is that you can't always fulfill all of these 3 conditions. "Easier" doesn't mean that the other case is impossible, just less likely.

> Thanks,
> Rémi
>

Remi Galan Alfonso· Apr 5, 2016, 14:17 UTC · re: Michael J Gruber · lore

Re: [RFC/PATCH] git.spec: fix changelog dates

Michael J Gruber <git@drmicha.warpmail.net> wrote:

Show 51 quoted lines

> Remi Galan Alfonso venit, vidit, dixit 05.04.2016 14:28:
> > Michael J Gruber <git@drmicha.warpmail.net> wrote:
> >> A few changelog entries have inconsistent dates, which rpmlint reports
> >> as errors.
> >>
> >> Fix them based on these assumptions:
> >> - It's easier to mistype a number than a weekday abbreviation.
> >> - changelog date must be before git commit date
> >> - The mistyped date is just a few days off.
> >>
> >> Signed-off-by: Michael J Gruber <git@drmicha.warpmail.net>
> >> ---
> >> I dunno if this is worthwhile, but rpmlint is the first thing we tell
> >> packagers and reviewers to check.
> >>
> >>  git.spec.in | 8 ++++----
> >>  1 file changed, 4 insertions(+), 4 deletions(-)
> >>
> >> diff --git a/git.spec.in b/git.spec.in
> >> index bfd1cfb..eb581a3 100644
> >> --- a/git.spec.in
> >> +++ b/git.spec.in
> >> @@ -229,7 +229,7 @@ rm -rf $RPM_BUILD_ROOT
> >>  * Sat Jan 30 2010 Junio C Hamano <gitster@pobox.com>
> >>  - We don't ship Python bits until a real foreign scm interface comes.
> >>  
> >> -* Mon Feb 04 2009 David J. Mellor <dmellor@whistlingcat.com>
> >> +* Mon Feb 02 2009 David J. Mellor <dmellor@whistlingcat.com>
> >>  - fixed broken git help -w after renaming the git-core package to git.
> >>  
> >>  * Fri Sep 12 2008 Quy Tonthat <qtonthat@gmail.com>
> >> @@ -262,7 +262,7 @@ rm -rf $RPM_BUILD_ROOT
> >>  * Thu Jun 21 2007 Shawn O. Pearce <spearce@spearce.org>
> >>  - Added documentation files for git-gui
> >>  
> >> -* Tue May 13 2007 Quy Tonthat <qtonthat@gmail.com>
> >> +* Sun May 13 2007 Quy Tonthat <qtonthat@gmail.com>
> >
> > It is inconsistent with what you said in the commit message ("It's
> > easier to mistype a number than a weekday abbreviation.").
> >
> > Following that logic, it should be:
> >         * Tue May 15 2007 Quy Tonthat <qtonthat@gmail.com>
> >
> > (or 08, I didn't check the condition "changelog date must be before
> > git commit date")
> 
> I did.
> 
> The thing is that you can't always fulfill all of these 3 conditions.
> "Easier" doesn't mean that the other case is impossible, just less likely.

Ah alright. Makes sense then, it is much harder to mistype 13 from 08 than from 15.

Sorry for the noise.

Thanks, Rémi