From: Remi Galan Alfonso Date: Tue, 05 Apr 2016 12:28:36 GMT Subject: Re: [RFC/PATCH] git.spec: fix changelog dates Message-ID: <833355852.2977267.1459859316816.JavaMail.zimbra@ensimag.grenoble-inp.fr> In-Reply-To: <6ef7d9d87f0c14147267c44e8b382f988936875b.1459858117.git.git@drmicha.warpmail.net> Michael J Gruber wrote: > A few changelog entries have inconsistent dates, which rpmlint reports > as errors. > > Fix them based on these assumptions: > - It's easier to mistype a number than a weekday abbreviation. > - changelog date must be before git commit date > - The mistyped date is just a few days off. > > Signed-off-by: Michael J Gruber > --- > I dunno if this is worthwhile, but rpmlint is the first thing we tell > packagers and reviewers to check. > > git.spec.in | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/git.spec.in b/git.spec.in > index bfd1cfb..eb581a3 100644 > --- a/git.spec.in > +++ b/git.spec.in > @@ -229,7 +229,7 @@ rm -rf $RPM_BUILD_ROOT > * Sat Jan 30 2010 Junio C Hamano > - We don't ship Python bits until a real foreign scm interface comes. > > -* Mon Feb 04 2009 David J. Mellor > +* Mon Feb 02 2009 David J. Mellor > - fixed broken git help -w after renaming the git-core package to git. > > * Fri Sep 12 2008 Quy Tonthat > @@ -262,7 +262,7 @@ rm -rf $RPM_BUILD_ROOT > * Thu Jun 21 2007 Shawn O. Pearce > - Added documentation files for git-gui > > -* Tue May 13 2007 Quy Tonthat > +* Sun May 13 2007 Quy Tonthat It is inconsistent with what you said in the commit message ("It's easier to mistype a number than a weekday abbreviation."). Following that logic, it should be: * Tue May 15 2007 Quy Tonthat (or 08, I didn't check the condition "changelog date must be before git commit date") Thanks, Rémi