git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCHv3 1/8] Introduce commit notes

From
Alex Riesen <raa.lkml@gmail.com>
Date
Jul 29, 2009, 08:52 UTC
Message-ID
<81b0412b0907290152w27c1b5b5l9efbd6980d4f904e@mail.gmail.com>
In-Reply-To
<1248834326-31488-2-git-send-email-johan@herland.net>
On Wed, Jul 29, 2009 at 04:25, Johan Herland<johan@herland.net> wrote:
> +void get_commit_notes(const struct commit *commit, struct strbuf *sb,
> +               const char *output_encoding)
> +{
> +       static const char *utf8 = "utf-8";
Using an array
  const char utf8[] = "utf-8";
costs you less BSS (no separate storage for the pointer).
Show 5 quoted lines
> @@ -963,5 +964,9 @@ void pretty_print_commit(enum cmit_fmt fmt, const struct commit *commit,
> +
> +       if (fmt != CMIT_FMT_ONELINE)
> +               get_commit_notes(commit, sb, encoding);
> +

Someday we will need a way to switch off the display of notes without resolving to oneline format. Is there a notes specifier for the printf-like log message formatting (--pretty=format: or --format) planned, BTW?

Previous: Johan HerlandNext: Johannes Schindelin
Message 3 of 30 in “[PATCHv3 0/8] RESEND: git notes”
  1. Johan HerlandJul 29, 2009
  2. 1/8 Introduce commit notesJohan Herland, Jul 29, 2009
  3. Alex RiesenJul 29, 2009
  4. Johannes SchindelinJul 29, 2009
  5. Johan HerlandJul 30, 2009
  6. Johannes SchindelinJul 30, 2009
  7. Johan HerlandJul 30, 2009
  8. 2/8 Add a script to edit/inspect notesJohan Herland, Jul 29, 2009
  9. 3/8 Speed up git notes lookupJohan Herland, Jul 29, 2009
  10. 4/8 Add an expensive test for git-notesJohan Herland, Jul 29, 2009
  11. 5/8 Teach "-m <msg>" and "-F <file>" to "git notes edit"Johan Herland, Jul 29, 2009
  12. Thomas RastJul 29, 2009
  13. Johan HerlandJul 30, 2009
  14. 6/8 First draft of notes tree parser with support for fanout subtreesJohan Herland, Jul 29, 2009
  15. Johannes SchindelinJul 29, 2009
  16. Testing performance of the notes lookup code (Was: [PATCHv3 6/8] First draft of notes tree parser with support for fanout subtrees)Johan Herland, Jul 30, 2009
  17. [RFC] First draft of 256-tree structure for storing notesJohan Herland, Aug 1, 2009
  18. [RFC] Store subtree entries in the same hash map as the note entriesJohan Herland, Aug 13, 2009
  19. [RFC] Use a 16-tree instead of a 256-tree for storing notesJohan Herland, Aug 26, 2009
  20. Alex RiesenAug 26, 2009
  21. Johan HerlandAug 26, 2009
  22. Alex RiesenAug 26, 2009
  23. Andreas EricssonAug 26, 2009
  24. Johan HerlandAug 26, 2009
  25. Johannes SchindelinAug 27, 2009
  26. 7/8 fast-import: Add support for importing commit notesJohan Herland, Jul 29, 2009
  27. Shawn O. PearceJul 29, 2009
  28. Johan HerlandJul 30, 2009
  29. 8/8 t3302-notes-index-expensive: Speed up create_repo()Johan Herland, Jul 29, 2009
  30. Johannes SchindelinJul 29, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.