From: Alex Riesen <raa.lkml@gmail.com>
Date: Wed, 29 Jul 2009 08:52:56 GMT
Subject: Re: [PATCHv3 1/8] Introduce commit notes
Message-ID: <81b0412b0907290152w27c1b5b5l9efbd6980d4f904e@mail.gmail.com>
In-Reply-To: <1248834326-31488-2-git-send-email-johan@herland.net>

On Wed, Jul 29, 2009 at 04:25, Johan Herland<johan@herland.net> wrote:
> +void get_commit_notes(const struct commit *commit, struct strbuf *sb,
> +               const char *output_encoding)
> +{
> +       static const char *utf8 = "utf-8";

Using an array

  const char utf8[] = "utf-8";

costs you less BSS (no separate storage for the pointer).

> @@ -963,5 +964,9 @@ void pretty_print_commit(enum cmit_fmt fmt, const struct commit *commit,
> +
> +       if (fmt != CMIT_FMT_ONELINE)
> +               get_commit_notes(commit, sb, encoding);
> +

Someday we will need a way to switch off the display of notes
without resolving to oneline format.
Is there a notes specifier for the printf-like log message formatting
(--pretty=format: or --format) planned, BTW?