git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Use "git_config_string" to simplify "remote.c" code in "handle_config"

From
Alex Riesen <raa.lkml@gmail.com>
Date
Oct 4, 2008, 22:46 UTC
Message-ID
<81b0412b0810041546w5eed8859vd8266bb66425ebd3@mail.gmail.com>
In-Reply-To
<20081003200613.GO20571@eratosthenes.cryptobackpack.org>
2008/10/3 David Bryson <david@statichacks.org>:
Show 9 quoted lines
> On Fri, Oct 03, 2008 at 07:28:42AM +0200 or thereabouts, Andreas Ericsson wrote:
>> David Bryson wrote:
> Oh I agree entirely, it is quite vague, however like I mentioned I tried
> to keep to the conventios in the file.  This strategy(v) is used in several
> other places in remote.c, if this is Bad Code, then I have no problem
> changing it.
>
> Thoughts from anybody else ?
>

You can redeclare of the variable in the contexts where it is used and not even rename it: it is close to its users then.

Previous: David BrysonNext: David Bryson
Message 4 of 7 in “Use "git_config_string" to simplify "remote.c" code in "handle_config"”
  1. Use "git_config_string" to simplify "remote.c" code in "handle_config"David Bryson, Oct 3, 2008
  2. Andreas EricssonOct 3, 2008
  3. David BrysonOct 3, 2008
  4. Alex RiesenOct 4, 2008
  5. David BrysonOct 6, 2008
  6. Johannes SchindelinOct 6, 2008
  7. David BrysonOct 6, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.