git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Use "git_config_string" to simplify "remote.c" code in "handle_config"

From
David Bryson <david@statichacks.org>
Date
Oct 3, 2008, 20:06 UTC
Message-ID
<20081003200613.GO20571@eratosthenes.cryptobackpack.org>
In-Reply-To
<48E5AD8A.4070301@op5.se>
On Fri, Oct 03, 2008 at 07:28:42AM +0200 or thereabouts, Andreas Ericsson wrote:
Show 23 quoted lines
> David Bryson wrote:
>> Signed-off-by: David Bryson <david@statichacks.org>
>> I tried to keep with the naming/coding conventions that I found in
>> remote.c.  Feedback welcome.
>> ---
>>  remote.c |   19 ++++++++++---------
>>  1 files changed, 10 insertions(+), 9 deletions(-)
>> diff --git a/remote.c b/remote.c
>> index 3f3c789..893a739 100644
>> --- a/remote.c
>> +++ b/remote.c
>> @@ -305,6 +305,7 @@ static int handle_config(const char *key, const char 
>> *value, void *cb)
>>  {
>>  	const char *name;
>>  	const char *subkey;
>> +	const char *v;
>
>
> Not very mnemonic. I'm sure you can think up a better name, even if it's
> a long one. Git is notoriously sparse when it comes to comments. We rely
> instead on self-explanatory code.
>

Oh I agree entirely, it is quite vague, however like I mentioned I tried to keep to the conventios in the file. This strategy(v) is used in several other places in remote.c, if this is Bad Code, then I have no problem changing it.

Thoughts from anybody else ?
Previous: Andreas EricssonNext: Alex Riesen
Message 3 of 7 in “Use "git_config_string" to simplify "remote.c" code in "handle_config"”
  1. Use "git_config_string" to simplify "remote.c" code in "handle_config"David Bryson, Oct 3, 2008
  2. Andreas EricssonOct 3, 2008
  3. David BrysonOct 3, 2008
  4. Alex RiesenOct 4, 2008
  5. David BrysonOct 6, 2008
  6. Johannes SchindelinOct 6, 2008
  7. David BrysonOct 6, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.