From: Alex Riesen Date: Sat, 04 Oct 2008 22:46:29 GMT Subject: Re: [PATCH] Use "git_config_string" to simplify "remote.c" code in "handle_config" Message-ID: <81b0412b0810041546w5eed8859vd8266bb66425ebd3@mail.gmail.com> In-Reply-To: <20081003200613.GO20571@eratosthenes.cryptobackpack.org> 2008/10/3 David Bryson : > On Fri, Oct 03, 2008 at 07:28:42AM +0200 or thereabouts, Andreas Ericsson wrote: >> David Bryson wrote: > Oh I agree entirely, it is quite vague, however like I mentioned I tried > to keep to the conventios in the file. This strategy(v) is used in several > other places in remote.c, if this is Bad Code, then I have no problem > changing it. > > Thoughts from anybody else ? > You can redeclare of the variable in the contexts where it is used and not even rename it: it is close to its users then.