Re: [PATCH] remove inline iteration variable

From: Alex Riesen <raa.lkml@gmail.com>
Date: Aug 17, 2006, 09:11 UTC
Message-ID: <81b0412b0608170211p7289889av43eb7c35ba07fe02@mail.gmail.com>
In-Reply-To: <Pine.LNX.4.63.0608161441070.29566@chino.corp.google.com>

On 8/16/06, David Rientjes <rientjes@google.com> wrote:

Show 18 quoted lines

> > > > > Remove unnecessary iteration variable in inline.
> > > > > -       for (i = 0; i < in; i++) putchar(' ');
> > > > > +       for (; in > 0; in--)
> > > >
> > > > while(in--) putchar(' ');
> > > >
> > >
> > > That goes into an infinite loop if the argument is negative because
> > > it emits a cmpl $0, x(%ebp).  Should never happen, but there's no
> > > reason not to prevent it with a for loop.
> >
> > while (in-- > 0) putchar(' ');
> >
> > still shorter :)
> >
>
> It emits a slightly rearranged assembly with the same number of instructions.
>

oops. I should've looked at the output. But the point moot anyway, Junio says :)