Re: [PATCH] remove inline iteration variable

From: Alex Riesen <fork0@t-online.de>
Date: Aug 16, 2006, 20:10 UTC
Message-ID: <20060816201019.GA6083@steel.home>
In-Reply-To: <Pine.LNX.4.63.0608161011100.20470@chino.corp.google.com>

David Rientjes, Wed, Aug 16, 2006 19:14:44 +0200:

Show 10 quoted lines

> > > Remove unnecessary iteration variable in inline.
> > > -       for (i = 0; i < in; i++) putchar(' ');
> > > +       for (; in > 0; in--)
> > 
> > while(in--) putchar(' ');
> > 
> 
> That goes into an infinite loop if the argument is negative because
> it emits a cmpl $0, x(%ebp).  Should never happen, but there's no
> reason not to prevent it with a for loop.

while (in-- > 0) putchar(' ');

still shorter :)