Re: [PATCH] remove inline iteration variable

From: Junio C Hamano <junkio@cox.net>
Date: Aug 16, 2006, 20:16 UTC
Message-ID: <7vzme4307d.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <20060816201019.GA6083@steel.home>

fork0@t-online.de (Alex Riesen) writes:

Show 15 quoted lines

> David Rientjes, Wed, Aug 16, 2006 19:14:44 +0200:
>> > > Remove unnecessary iteration variable in inline.
>> > > -       for (i = 0; i < in; i++) putchar(' ');
>> > > +       for (; in > 0; in--)
>> > 
>> > while(in--) putchar(' ');
>> > 
>> 
>> That goes into an infinite loop if the argument is negative because
>> it emits a cmpl $0, x(%ebp).  Should never happen, but there's no
>> reason not to prevent it with a for loop.
>
> while (in-- > 0) putchar(' ');
>
> still shorter :)

Why do we keep talking about a usually ifdef'ed out debugging section?

I'll be removing that section altogether ;-).