Re: remove perl from git-commit.sh

From: Alex Riesen <raa.lkml@gmail.com>
Date: Jul 12, 2006, 12:23 UTC
Message-ID: <81b0412b0607120523t34cfb92bs872f6d45b1b48759@mail.gmail.com>
In-Reply-To: <20060712114805.GD13776@pasky.or.cz>

On 7/12/06, Petr Baudis <pasky@suse.cz> wrote:

> BTW, why people so often want to keep stuff like the following from
> commit messages?

Well, strictly speaking it isn't the description of what the patch does.

Show 6 quoted lines

> > than having to constantly patch git-commit.sh for binmode
> > or perl path (Windows has no stable tool set, and perl
> > for instance often resides "somewhere").
>
> ...but I would prefer much better if we could actually fix the problem.
> I'm not sure what "patching for binmode" takes but it sounds that we

ActiveState Perl normally replaces \n in the output with \r\n, which is annoying, as the rest of git does output \n verbatim.

> should do it for the other Perl scripts anyway. If Cygwin usually really
> doesn't have stable Perl path, you could special-case PERL_PATH in

It's not cygwin. It's an organization typical for windows environements: stinky trash can.

> Makefile for Cygwin to be just "perl" (or perhaps that's the issue only
> for non-source packages so you might want to simply set PERL_PATH to
> perl when building those).

I did. I didn't mention it because the patch was about the binmode. sh is from cygwin here, so just removing this one dependency helps a lot. I will change other scripts as soon as they get problematic.

Another small problem is with windows pathnames (activestate perl expects _windows_ path, but allows forward slashes in it: c:/a/b/c). I have calls to cygpath (converts cygwin path to windows and vice versa) all over (not everywhere, just clone, rerere, mv, shortlog and fmt-merge-msg. The tools that were important to me) just to deal with this. It's a horribly unstable and poorly tested and breaks from time to time but it mostly works. As I saw no complaints here about the same problem I have never submitted the changes. Maybe I am just unlucky to have to deal with windows so often.