remove perl from git-commit.sh

It is really annoying when the essentials do not work. I think we could improve at least them, by minimizing their dependencies to external tools.

---

git-commit.sh has only ohne place where perl is used and it can actually quite trivially be done in sh. git-ls-files without "-z" produces quoted output, even if is different from that produced by perl code it could be enough. Otherwise I'd better suggest to add another quoting style (replacing only \t, \n and backslash) than having to constantly patch git-commit.sh for binmode or perl path (Windows has no stable tool set, and perl for instance often resides "somewhere").

From 69bf41df4ef69d0f1e4ab52942c59bb3fd568cb8 Mon Sep 17 00:00:00 2001
From: Alex Riesen <raa.lkml@gmail.com>
Date: Wed, 12 Jul 2006 13:02:23 +0200
Subject: remove perl from git-commit.sh
---
 git-commit.sh |   32 +++++++++++++-------------------
 1 files changed, 13 insertions(+), 19 deletions(-)

On 7/12/06, Alex Riesen <raa.lkml@gmail.com> wrote:

One could always do the quoting with sed, or am I missing something?

  nikolai

On 7/12/06, Nikolai Weibull <now@bitwi.se> wrote:

No, but if look closely at this list you'll find a lot of incompatibilities in sed too. So the less, the better

On 7/12/06, Alex Riesen <raa.lkml@gmail.com> wrote:

Well, that's true, of course, but something as "simple" as what is needed in this case should be possible. Anyway, I was just wondering what the motives were, not questioning them ;-).

  nikolai

On 7/12/06, Nikolai Weibull <now@bitwi.se> wrote:

Being forced to use ActiveState Perl on a W2K in a corporate environment.

Dear diary, on Wed, Jul 12, 2006 at 01:15:03PM CEST, I got a letter where Alex Riesen <raa.lkml@gmail.com> said that...

BTW, why people so often want to keep stuff like the following from commit messages?

Of course getting rid of Perl from the "essentials" is an option...

...but I would prefer much better if we could actually fix the problem. I'm not sure what "patching for binmode" takes but it sounds that we should do it for the other Perl scripts anyway. If Cygwin usually really doesn't have stable Perl path, you could special-case PERL_PATH in Makefile for Cygwin to be just "perl" (or perhaps that's the issue only for non-source packages so you might want to simply set PERL_PATH to perl when building those).

On 7/12/06, Petr Baudis <pasky@suse.cz> wrote:

Well, strictly speaking it isn't the description of what the patch does.

ActiveState Perl normally replaces \n in the output with \r\n, which is annoying, as the rest of git does output \n verbatim.

It's not cygwin. It's an organization typical for windows environements: stinky trash can.

I did. I didn't mention it because the patch was about the binmode. sh is from cygwin here, so just removing this one dependency helps a lot. I will change other scripts as soon as they get problematic.

Another small problem is with windows pathnames (activestate perl expects _windows_ path, but allows forward slashes in it: c:/a/b/c). I have calls to cygpath (converts cygwin path to windows and vice versa) all over (not everywhere, just clone, rerere, mv, shortlog and fmt-merge-msg. The tools that were important to me) just to deal with this. It's a horribly unstable and poorly tested and breaks from time to time but it mostly works. As I saw no complaints here about the same problem I have never submitted the changes. Maybe I am just unlucky to have to deal with windows so often.

"Alex Riesen" <raa.lkml@gmail.com> writes:

(1) Sign-off?

(2) I think the cover letter comment talks more apporpirate
    things than your proposed commit message.  The commit log is
    not a place to vent your frustration.  It's where you
    justify why that change was needed for people who will want
    to figure out why your patch broke their workflow later.

I do not think anybody parses git-status output to figure out the list of paths that are touched/untracked/etc., so I am not opposed to this change itself.

git-commit.sh has the only one place where perl is used and there it can quite trivially be done in sh.

git-ls-files without "-z" produces quoted output, even if is different from that produced by perl code it could be enough. Otherwise I'd better suggest to add another quoting style (replacing only \t, \n and backslash).

This system is an ugly combination of cygwin and activestate perl. The combination has some quirks (like the perl producing \r\n by default, expecting windows pathnames instead of cygwin fakes, or ignoring environment variables under some hard to reproduce circumstances), so reducing number of this interactions reduces number of hacks one has to put in core code to make things work. I used to patch git-commit.sh to put binmode in perl output, and git-clone.sh still has these calls to cygpath.

Signed-off-by: Alex Riesen <raa.lkml@gmail.com>

---

It is really annoying when the essentials do not work. I think we could improve at least them, by minimizing their dependencies to external tools.

Junio C Hamano wrote:

done

done.

From 69bf41df4ef69d0f1e4ab52942c59bb3fd568cb8 Mon Sep 17 00:00:00 2001
From: Alex Riesen <raa.lkml@gmail.com>
Date: Wed, 12 Jul 2006 13:02:23 +0200
Subject: remove perl from git-commit.sh
---
 git-commit.sh |   32 +++++++++++++-------------------
 1 files changed, 13 insertions(+), 19 deletions(-)