Re: remove perl from git-commit.sh

From: Petr Baudis <pasky@suse.cz>
Date: Jul 12, 2006, 11:48 UTC
Message-ID: <20060712114805.GD13776@pasky.or.cz>
In-Reply-To: <81b0412b0607120415g243f2160tf42c40e52b8bc9ac@mail.gmail.com>

Dear diary, on Wed, Jul 12, 2006 at 01:15:03PM CEST, I got a letter where Alex Riesen <raa.lkml@gmail.com> said that...

> ---

BTW, why people so often want to keep stuff like the following from commit messages?

Show 6 quoted lines

> git-commit.sh has only ohne place where perl is used
> and it can actually quite trivially be done in sh.
> git-ls-files without "-z" produces quoted output, even if
> is different from that produced by perl code it could be
> enough. Otherwise I'd better suggest to add another
> quoting style (replacing only \t, \n and backslash)

Of course getting rid of Perl from the "essentials" is an option...

> than having to constantly patch git-commit.sh for binmode
> or perl path (Windows has no stable tool set, and perl
> for instance often resides "somewhere").

...but I would prefer much better if we could actually fix the problem. I'm not sure what "patching for binmode" takes but it sounds that we should do it for the other Perl scripts anyway. If Cygwin usually really doesn't have stable Perl path, you could special-case PERL_PATH in Makefile for Cygwin to be just "perl" (or perhaps that's the issue only for non-source packages so you might want to simply set PERL_PATH to perl when building those).

-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
Snow falling on Perl. White noise covering line noise.
Hides all the bugs too. -- J. Putnam