git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] use "git init-db" in tests

From
Alex Riesen <raa.lkml@gmail.com>
Date
Dec 9, 2005, 10:59 UTC
Message-ID
<81b0412b0512090259l5f06f6d6n5416e271af36d6a1@mail.gmail.com>
In-Reply-To
<7vlkyu7l05.fsf@assigned-by-dhcp.cox.net>
On 12/9/05, Junio C Hamano <junkio@cox.net> wrote:
Show 9 quoted lines
> > An accident? Like a filesystem not supporting executable permission?
> > What is the reason to report success from the test run in that conditions?
>
> Let's be reasonable.  I was hoping to hear from you a real-world
> breakage case that I overlooked due to my lack of access to
> platforms you may have access to. I am not interested in a
> theoretical failure case discussion very much.  If your
> filesystem does not support executables, why do you expect
> things to run from the freshly built directory to begin with?

In my case it was the freshly build directory where a chmod 0666 * was done. This directory wont rebuild (the dates are correct), and the tests run, as if nothing happened. I actually noticed only after a half an hour, that I wasn't running the executables I expected.

Show 9 quoted lines
> Linkage error of git-init-db (or git wrapper) may leave the file
> created but leave that in unexecutable form, which could be a
> valid concern, but that would signal an error to the make during
> the build stage, and "test" target depends on "all" target.
>
> And please do not start arguing that you can cd to 't' directory
> after such a build failure and manually say "make".  You can do
> that without even running make at the top level and cause the
> same failure.  I consider both of them pilot errors.

Yes, but they are not obvious. It is also not obvious what to do, because everything seams alright.

Previous: Petr BaudisNext: Junio C Hamano
Message 9 of 11 in “use "git init-db" in tests”
  1. use "git init-db" in testsAlex Riesen, Dec 8, 2005
  2. Junio C HamanoDec 8, 2005
  3. Alex RiesenDec 8, 2005
  4. Junio C HamanoDec 8, 2005
  5. Alex RiesenDec 9, 2005
  6. Junio C HamanoDec 9, 2005
  7. Junio C HamanoDec 9, 2005
  8. Petr BaudisDec 9, 2005
  9. Alex RiesenDec 9, 2005
  10. Junio C HamanoDec 9, 2005
  11. Alex RiesenDec 8, 2005

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.