git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] use "git init-db" in tests

From
Alex Riesen <raa.lkml@gmail.com>
Date
Dec 8, 2005, 20:25 UTC
Message-ID
<20051208202555.GA3046@steel.home>

Unless there was a special reason to use git-init-db from $PATH, could the patch below be accepted? It makes the test suite use git-init-db from the "the binaries we have just built".

The reason, why we need the patch even if the $PATH is set, will be better explained by glibc's sources: the lookup does not stop if the file exists but has no execute permission.

See file posix/execvp.c, the loop iterating over elements in $PATH:
          switch (errno)
            {
            case EACCES:
              /* Record the we got a `Permission denied' error.  If we end
                 up finding no executable we can use, we want to diagnose
                 that we did find one but were denied access.  */
              got_eacces = true;
                 ...
              break;
            ...
            }
      ...
      /* We tried every element and none of them worked.  */
      if (got_eacces)
        /* At least one failure was due to permissions, so report that
           error.  */
        __set_errno (EACCES);
Signed-off-by: Alex Riesen <raa.lkml@gmail.com>
---
 By the same reason, the whole testsuite should be reviewed to use 
 "git <command>" notation.
 t/test-lib.sh |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
4417503d10870c913cff4f635acf274b7da75864
diff --git a/t/test-lib.sh b/t/test-lib.sh
index 0539dac..3704e5f 100755
--- a/t/test-lib.sh
+++ b/t/test-lib.sh
@@ -190,8 +190,8 @@ test=trash
 rm -fr "$test"
 mkdir "$test"
 cd "$test"
-git-init-db --template=../../templates/blt/ 2>/dev/null ||
-error "cannot run git-init-db"
+git init-db --template=../../templates/blt/ 2>/dev/null ||
+error "cannot run git init-db"
 
 mv .git/hooks .git/hooks-disabled
 
-- 
0.99.9.GIT
Next: Junio C Hamano
Message 1 of 11 in “use "git init-db" in tests”
  1. use "git init-db" in testsAlex Riesen, Dec 8, 2005
  2. Junio C HamanoDec 8, 2005
  3. Alex RiesenDec 8, 2005
  4. Junio C HamanoDec 8, 2005
  5. Alex RiesenDec 9, 2005
  6. Junio C HamanoDec 9, 2005
  7. Junio C HamanoDec 9, 2005
  8. Petr BaudisDec 9, 2005
  9. Alex RiesenDec 9, 2005
  10. Junio C HamanoDec 9, 2005
  11. Alex RiesenDec 8, 2005

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.