Re: [PATCH] use "git init-db" in tests

From: Alex Riesen <raa.lkml@gmail.com>
Date: Dec 8, 2005, 21:02 UTC
Message-ID: <20051208210251.GB19423@steel.home>
In-Reply-To: <7vu0dje2oi.fsf@assigned-by-dhcp.cox.net>

Junio C Hamano, Thu, Dec 08, 2005 21:47:41 +0100:

Show 9 quoted lines

> 
> > Unless there was a special reason to use git-init-db from $PATH, could
> > the patch below be accepted? It makes the test suite use git-init-db
> > from the "the binaries we have just built".
> 
> A few lines above what you patched we do make sure the PATH
> starts with the top of the build directory where you would find
> git-init-db we have just built, so unless I am missing something...
>

You do miss something. glibc will happily continue lookup if git-init-db in the top of the build directory is not executable, and it will take the next one it finds (and people _will_ have git-init-db in PATH).