git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: make gitfakemmap standalone to fix linking error in git.c

From
Alex Riesen <raa.lkml@gmail.com>
Date
Dec 5, 2005, 13:24 UTC
Message-ID
<81b0412b0512050524w7b632651n93c836fda41a39d@mail.gmail.com>
In-Reply-To
<81b0412b0512050519k5ed80035x9eb4907f569e0a4b@mail.gmail.com>

The patch is to fix the error introduced by previous patch, which inverted condition of checking for the supported case (start must be NULL).

On 12/5/05, Alex Riesen <raa.lkml@gmail.com> wrote:
> The patch is to fix linking error because of gitfakemmap referencing
> die living in usage.c, and git.c not linking in the file. Instead of
> hardcoding usage.o in git.c prerequisites, I separated mmap from the
> main sources.
Why does it always happen...
Subject: [PATCH] fix bug introduced by previous change
Signed-off-by: Alex Riesen <ariesen@harmanbecker.com>
---
 compat/mmap.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
58d38f03086fe30f3f758f2f27fde0ad05107b4a
diff --git a/compat/mmap.c b/compat/mmap.c
index 98cf3cb..cfa1f25 100644
--- a/compat/mmap.c
+++ b/compat/mmap.c
@@ -9,7 +9,7 @@ void *gitfakemmap(void *start, size_t le
 {
 	int n = 0;
 
-	if (!start || !(flags & MAP_PRIVATE)) {
+	if (start || !(flags & MAP_PRIVATE)) {
 		fprintf(stderr, "Invalid usage of gitfakemmap.\n");
 		exit(128); /* see die() in ../usage.c */
 	}
-- 
0.99.9.GIT
Previous: Alex RiesenNext: Petr Baudis
Message 2 of 23 in “make gitfakemmap standalone to fix linking error in git.c”
  1. Alex RiesenDec 5, 2005
  2. Alex RiesenDec 5, 2005
  3. Petr BaudisDec 5, 2005
  4. Alex RiesenDec 5, 2005
  5. Junio C HamanoDec 5, 2005
  6. Clean up compatibility definitions.Junio C Hamano, Dec 5, 2005
  7. Johannes SchindelinDec 5, 2005
  8. Junio C HamanoDec 5, 2005
  9. Alex RiesenDec 5, 2005
  10. Alex RiesenDec 6, 2005
  11. Junio C HamanoDec 6, 2005
  12. Alex RiesenDec 5, 2005
  13. Junio C HamanoDec 5, 2005
  14. Alex RiesenDec 6, 2005
  15. Junio C HamanoDec 6, 2005
  16. Alex RiesenDec 6, 2005
  17. Junio C HamanoDec 6, 2005
  18. Petr BaudisDec 5, 2005
  19. Junio C HamanoDec 6, 2005
  20. Petr BaudisDec 6, 2005
  21. Alex RiesenDec 5, 2005
  22. Junio C HamanoDec 5, 2005
  23. Alex RiesenDec 6, 2005

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.