Re: make gitfakemmap standalone to fix linking error in git.c

From: Petr Baudis <pasky@suse.cz>
Date: Dec 5, 2005, 14:11 UTC
Message-ID: <20051205141141.GF22159@pasky.or.cz>
In-Reply-To: <81b0412b0512050524w7b632651n93c836fda41a39d@mail.gmail.com>

Dear diary, on Mon, Dec 05, 2005 at 02:24:47PM CET, I got a letter where Alex Riesen <raa.lkml@gmail.com> said that...

Show 11 quoted lines

> The patch is to fix the error introduced by previous patch, which
> inverted condition of checking for the supported case (start must be
> NULL).
> 
> On 12/5/05, Alex Riesen <raa.lkml@gmail.com> wrote:
> > The patch is to fix linking error because of gitfakemmap referencing
> > die living in usage.c, and git.c not linking in the file. Instead of
> > hardcoding usage.o in git.c prerequisites, I separated mmap from the
> > main sources.
> 
> Why does it always happen...

Possibly not worth yet another patch submission now, but in general I believe it's better to send new revision of the original patch rather than another patch on top of the previous one.

-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
VI has two modes: the one in which it beeps and the one in which
it doesn't.