Re: [PATCH] Clean up compatibility definitions.

From: Petr Baudis <pasky@suse.cz>
Date: Dec 6, 2005, 09:53 UTC
Message-ID: <20051206095314.GZ10680@pasky.or.cz>
In-Reply-To: <7vacfe9amx.fsf@assigned-by-dhcp.cox.net>

Dear diary, on Tue, Dec 06, 2005 at 04:17:58AM CET, I got a letter where Junio C Hamano <junkio@cox.net> said that...

Show 16 quoted lines

> Petr Baudis <pasky@suse.cz> writes:
> 
> > Dear diary, on Mon, Dec 05, 2005 at 09:22:42PM CET, I got a letter
> > where Junio C Hamano <junkio@cox.net> said that...
> >> diff --git a/git-compat-util.h b/git-compat-util.h
> >> new file mode 100644
> >
> > What about compat/util.h or something? Nicer, shorter, and takes
> > advantage of this fancy hierarchical namespace "directories" invention.
> > ;-)
> 
> While I would appreciate a better name, I am afraid that is not a
> particularly good one.  It is not "compatibility utilities", but
> compat things and util things mixed together, so it does not
> belong to compat/ directory to begin with.  die() and friends
> are not about compatibility at all.

Then perhaps the .h file should be split? At least the "compat-util" name did not suggest combination to me, but specialization (not "compatibility and utils" but "compatibility utils").

-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
VI has two modes: the one in which it beeps and the one in which
it doesn't.