git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC] [PATCH] remote: add new --fetch option for set-url

From
Peter Wu <peter@lekensteyn.nl>
Date
Nov 25, 2014, 11:36 UTC
Message-ID
<8034833.1FhY2A8KSQ@al>
In-Reply-To
<20141125040826.GC19301@peff.net>
On Monday 24 November 2014 23:08:26 Jeff King wrote:
Show 5 quoted lines
> However, I think what removed the confusion for me in your --only=both
> proposal was the presence of a "both" option, since it made it more
> clear that is not what no-option means. So what about just "--push",
> "--fetch", and "--both"? Explain the current behavior of no-options in
> the documentation as a historical oddity.

Ok, this sounds even better. I have dropped the --only part and made the options --push, --fetch and --both disjoint (overriding each other). A patch will follow soon. Maybe it should warn when you try to specify both options though.

Show 9 quoted lines
> That also gives us an easy path forward for changing the behavior.
> During the transition period, people should use --push, --fetch, or
> --both. Using no-options provides a warning. After a settling period,
> the no-option behavior will switch to one of those (presumably --both),
> and drop the warning.
> 
> You do not have to do the migration path if you don't want to. Adding
> "--fetch" and "--both" scratches your itch and sets us up to migrate
> later.

I have documented the historic behavior and mentioned that it is /possible/ that the option --both becomes default in the future.

Show 10 quoted lines
> > What about the translations? Should I send a separate patch for that or
> > can I update all translations at once?
> 
> You do not have to update the translations. When we near a release, the
> l10n coordinator will run "make pot" to update po/git.pot with the
> strings marked for translation, and then the translators will write
> translations for the new strings. You are of course welcome to help with
> the translation effort at that stage. 
> 
> Details are in po/README.

Well, it is not necessary the translations, but the format of them. The format "git remote set-url --delete <name> <url>" has changed to "git remote set-url [--both | --fetch | --push] --delete <name> <url>" for example. The old strings are still usable, so I wonder whether I can make it easier for the i10n maintainer to recognize this change?

-- 
Kind regards,
Peter
https://lekensteyn.nl
Previous: Jeff KingNext: Philip Oakley
Message 23 of 27 in “remote: add new --fetch option for set-url”
  1. Peter WuNov 19, 2014
  2. Jeff KingNov 19, 2014
  3. Peter WuNov 19, 2014
  4. Jeff KingNov 19, 2014
  5. Peter WuNov 19, 2014
  6. Junio C HamanoNov 19, 2014
  7. Peter WuNov 19, 2014
  8. Junio C HamanoNov 19, 2014
  9. Junio C HamanoNov 19, 2014
  10. Junio C HamanoNov 19, 2014
  11. Peter WuNov 19, 2014
  12. Peter WuNov 24, 2014
  13. Junio C HamanoNov 24, 2014
  14. Peter WuNov 24, 2014
  15. Jeff KingNov 24, 2014
  16. Peter WuNov 24, 2014
  17. Jeff KingNov 24, 2014
  18. Junio C HamanoNov 24, 2014
  19. Peter WuNov 24, 2014
  20. Jeff KingNov 25, 2014
  21. Junio C HamanoNov 25, 2014
  22. Jeff KingNov 25, 2014
  23. Peter WuNov 25, 2014
  24. Philip OakleyNov 28, 2014
  25. Peter WuDec 2, 2014
  26. Junio C HamanoDec 2, 2014
  27. Peter WuNov 25, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.