Re: [PATCH] git-fetch --tags: deal with tags with spaces in them.

From: Junio C Hamano <junkio@cox.net>
Date: Oct 11, 2005, 06:04 UTC
Message-ID: <7vzmpgy4g4.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <7virw4zlod.fsf_-_@assigned-by-dhcp.cox.net>

Junio C Hamano <junkio@cox.net> writes:

> "git-fetch --tags" can get confused with tags with spaces in their names,
> it used to use shell IFS to split the list of tags and also used curl
> which insists the URL to be escaped.  Fix it so it can work with Martin's
> moodle repository http://locke.catalyst.net.nz/git/moodle.git/.

The one I sent to the list was buggy and broke usual multi-head fetches, and what I have in the proposed updates branch is a replacement one.

We cannot still do arbitrary reference names, but at least now we allow spaces in them. But I am not sure if this is a good change.

Do we in general want to support references with [^-a-zA-Z0-9.] in them? Most notably spaces?

The current replacement patch implies that .git/remotes/ short-cut file format now has a slight incompatible change. You cannot have more than one refspec on single Pull: line. I used to have:

	Pull: master:ko-master +pu:ko-pu maint:ko-maint

but these should now be split into multiple lines, like this:

	Pull: master:ko-master
	Pull: +pu:ko-pu
	Pull: maint:ko-maint

The latter format, one refpair per line, has always been supported, BTW.

Opinions?