Re: [PATCH] git-fetch --tags: deal with tags with spaces in them.

From: H. Peter Anvin <hpa@zytor.com>
Date: Oct 12, 2005, 15:36 UTC
Message-ID: <434D2D8F.2020407@zytor.com>
In-Reply-To: <7vk6gjl2uu.fsf@assigned-by-dhcp.cox.net>

Junio C Hamano wrote:

Show 15 quoted lines

> 
> Here is mine.
> 
> I do not personally think it is too much of a restriction if we
> said we only allow tags using letters from [-a-zA-Z0-9.] (yes I
> am trying to be controversial by not allowing even latin-1
> names).  Even without going that far, if we just said we do not
> allow shell metacharacters in tagnames (i.e. assuming UTF-8
> encoded pathnames, non-ascii part of unicode character space is
> allowed), I suspect things will get much simpler to handle.
> 
> The troublesome tags Martin's repository had were autocreated
> with cvsimport.  That is something we could easily fix (I think
> we already do certain tagname munging).
>

I don't know about this. Saying we only support ASCII tagnames can be quote brutal for non-English-language projects. Even with the set above, we'd at the very least need underscore, and I know of at least one project which require # in tagnames. In short, I don't think we can make that decision for people.

We can disallow whitespace, and we *have* to disallow at least newline due to the file format; I believe we should disallow all control characters (0-31, 127-159.)

	-hpa