Re: [PATCH] git-fetch --tags: deal with tags with spaces in them.

From: Petr Baudis <pasky@suse.cz>
Date: Oct 12, 2005, 08:26 UTC
Message-ID: <20051012082632.GL30889@pasky.or.cz>
In-Reply-To: <7vk6gjl2uu.fsf@assigned-by-dhcp.cox.net>

Dear diary, on Wed, Oct 12, 2005 at 07:29:45AM CEST, I got a letter where Junio C Hamano <junkio@cox.net> told me that...

> I do not personally think it is too much of a restriction if we
> said we only allow tags using letters from [-a-zA-Z0-9.] (yes I
> am trying to be controversial by not allowing even latin-1
> names).

I think this is perfectly reasonable, as long as you also throw _ to the set. ;-) Actually, cg-tag now already does at least

(echo $name | egrep -qv '[^a-zA-Z0-9_.@!:-]') || \
        die "name contains invalid characters"

but I'm in no way emotionally attached to the @!: characters.

-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
VI has two modes: the one in which it beeps and the one in which
it doesn't.