git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] gitweb: fill in gitweb configuration by Makefile

From
Junio C Hamano <junkio@cox.net>
Date
Jul 31, 2006, 01:20 UTC
Message-ID
<7vzmeqa7tx.fsf@assigned-by-dhcp.cox.net>
In-Reply-To
<20060730223754.GA16364@admingilde.org>
Martin Waitz <tali@admingilde.org> writes:
Show 22 quoted lines
> diff --git a/gitweb/gitweb.cgi b/gitweb/gitweb.pl
> similarity index 100%
> rename from gitweb/gitweb.cgi
> rename to gitweb/gitweb.pl
> index 243a2921f849568260e848201d238b3b9fe7e1f2..8e05c335f801d4c52a9b348fa56fccfae36ce621 100755
> --- a/gitweb/gitweb.cgi
> +++ b/gitweb/gitweb.pl
> @@ -24,14 +24,14 @@ our $rss_link = "";
>  
>  # core git executable to use
>  # this can just be "git" if your webserver has a sensible PATH
> -our $GIT = "/usr/bin/git";
> +our $GIT = "@@GIT_BINDIR@@/git";
>  
>  # absolute fs-path which will be prepended to the project path
>  #our $projectroot = "/pub/scm";
> -our $projectroot = "/home/kay/public_html/pub/scm";
> +our $projectroot = "@@GITWEB_PROJECTROOT@@";
>  
>  # version of the core git binary
> -our $git_version = qx($GIT --version) =~ m/git version (.*)$/ ? $1 : "unknown";
> +our $git_version = "@@GIT_VERSION@@";

I think the other parts are sensible but I am not sure if we want to report the version of git distribution (your patch), or the version of git binary the cgi script happens to use (the current implementation).

Previous: Martin WaitzNext: Martin Waitz
Message 2 of 13 in “gitweb: fill in gitweb configuration by Makefile”
  1. gitweb: fill in gitweb configuration by MakefileMartin Waitz, Jul 30, 2006
  2. Junio C HamanoJul 31, 2006
  3. Martin WaitzJul 31, 2006
  4. Jakub NarebskiJul 31, 2006
  5. Martin WaitzAug 1, 2006
  6. Luben TuikovJul 31, 2006
  7. Luben TuikovJul 31, 2006
  8. Junio C HamanoJul 31, 2006
  9. Martin WaitzJul 31, 2006
  10. Johannes SchindelinJul 31, 2006
  11. Luben TuikovJul 31, 2006
  12. Jon LoeligerJul 31, 2006
  13. Jakub NarebskiJul 31, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.