Re: [PATCH] gitweb: fill in gitweb configuration by Makefile

From: Luben Tuikov <ltuikov@yahoo.com>
Date: Jul 31, 2006, 16:59 UTC
Message-ID: <20060731165904.78929.qmail@web31815.mail.mud.yahoo.com>
In-Reply-To: <20060731072200.GE16364@admingilde.org>

--- Martin Waitz <tali@admingilde.org> wrote:

Show 17 quoted lines

> > This way, I can just copy gitweb.cgi into my web-server directory
> > and voila it works, since the variable definition file would
> > always be there.  This way:
> >   - no need to run make to build "gitweb.cgi" or "gitweb.pl" whatever
> >     you call it,
> 
> ok, but you have to call make anyway to build the rest of GIT,
> so this shouldn't be a big problem.
> 
> >   - no need to pollute your tree with site defined variables,
> 
> this is achieved by my patch, too.
> 
> >   - simple copy (cp) would install a working version, instead of
> >     the current cp + patch with local settings method.
> 
> this is achieved by my patch, too.

That's true, but the difference is that one needs to keep a per-site-installation tree which keeps the configuration of gitweb for that site (installation).

Since you're working on this, can you come up with an alternative way? At this point I don't care either way, but _if_ there is an alternative way, I'd rather we considered it. (Possibly using a symbol table file ("package") to only keep those variables?)

The bash-sed editing is kind of, you have to admit, hackish.

   Luben