Re: [PATCH] gitweb: fill in gitweb configuration by Makefile

From: Luben Tuikov <ltuikov@yahoo.com>
Date: Jul 31, 2006, 08:14 UTC
Message-ID: <20060731081428.17416.qmail@web31807.mail.mud.yahoo.com>
In-Reply-To: <7vzmeqa7tx.fsf@assigned-by-dhcp.cox.net>

--- Junio C Hamano <junkio@cox.net> wrote:

Show 30 quoted lines

> Martin Waitz <tali@admingilde.org> writes:
> 
> > diff --git a/gitweb/gitweb.cgi b/gitweb/gitweb.pl
> > similarity index 100%
> > rename from gitweb/gitweb.cgi
> > rename to gitweb/gitweb.pl
> > index 243a2921f849568260e848201d238b3b9fe7e1f2..8e05c335f801d4c52a9b348fa56fccfae36ce621
> 100755
> > --- a/gitweb/gitweb.cgi
> > +++ b/gitweb/gitweb.pl
> > @@ -24,14 +24,14 @@ our $rss_link = "";
> >  
> >  # core git executable to use
> >  # this can just be "git" if your webserver has a sensible PATH
> > -our $GIT = "/usr/bin/git";
> > +our $GIT = "@@GIT_BINDIR@@/git";
> >  
> >  # absolute fs-path which will be prepended to the project path
> >  #our $projectroot = "/pub/scm";
> > -our $projectroot = "/home/kay/public_html/pub/scm";
> > +our $projectroot = "@@GITWEB_PROJECTROOT@@";
> >  
> >  # version of the core git binary
> > -our $git_version = qx($GIT --version) =~ m/git version (.*)$/ ? $1 : "unknown";
> > +our $git_version = "@@GIT_VERSION@@";
> 
> I think the other parts are sensible but I am not sure if we
> want to report the version of git distribution (your patch), or
> the version of git binary the cgi script happens to use (the
> current implementation).

I'd rather see git distribution (Martin's patch) since, after all, gitweb became part of git not so long ago. And as thus, its own numbers don't matter much, but the git distribution.

In fact, I was thinking of submitting a patch to the same effect myself.

    Luben