Re: [PATCH] Bisect: add checks at the beginning of "git bisect run".

From: Junio C Hamano <junkio@cox.net>
Date: Mar 27, 2007, 05:28 UTC
Message-ID: <7vzm5zs1aq.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <20070327064957.34dad72a.chriscool@tuxfamily.org>

Christian Couder <chriscool@tuxfamily.org> writes:

Show 16 quoted lines

> diff --git a/git-bisect.sh b/git-bisect.sh
> index fda1712..57d6754 100755
> --- a/git-bisect.sh
> +++ b/git-bisect.sh
> @@ -223,6 +223,14 @@ bisect_replay () {
>  }
>  
>  bisect_run () {
> +    # Check that we have everything to run correctly.
> +    test -d "$GIT_DIR/refs/bisect" || {
> +	echo >&2 'You need to start by "git bisect start".'
> +	echo >&2 'And then by "git bisect bad" and "git bisect good".'
> +	exit 1
> +    }
> +    bisect_next_check fail
> +

I think you shouldn't need the first "test -d blah"; doesn't "bisect_next_check fail" already give that message?

Show 5 quoted lines

>      while true
>      do
>        echo "running $@"
> -- 
> 1.5.1.rc2.2.gcc08