git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] Bisect: add checks at the beginning of "git bisect run".

From
Christian Couder <chriscool@tuxfamily.org>
Date
Mar 27, 2007, 04:49 UTC
Message-ID
<20070327064957.34dad72a.chriscool@tuxfamily.org>

We may be able to "run" with only one good revision given and then verify that the result of the first run is bad. And perhaps also the other way around.

But for now let's check that we have at least one bad and one good revision before we start to run.

Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
---
 git-bisect.sh |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/git-bisect.sh b/git-bisect.sh
index fda1712..57d6754 100755
--- a/git-bisect.sh
+++ b/git-bisect.sh
@@ -223,6 +223,14 @@ bisect_replay () {
 }
 
 bisect_run () {
+    # Check that we have everything to run correctly.
+    test -d "$GIT_DIR/refs/bisect" || {
+	echo >&2 'You need to start by "git bisect start".'
+	echo >&2 'And then by "git bisect bad" and "git bisect good".'
+	exit 1
+    }
+    bisect_next_check fail
+
     while true
     do
       echo "running $@"
-- 
1.5.1.rc2.2.gcc08
Next: Junio C Hamano
Message 1 of 13 in “Bisect: add checks at the beginning of "git bisect run".”
  1. Bisect: add checks at the beginning of "git bisect run".Christian Couder, Mar 27, 2007
  2. Junio C HamanoMar 27, 2007
  3. Christian CouderMar 27, 2007
  4. Junio C HamanoMar 27, 2007
  5. Junio C HamanoMar 27, 2007
  6. Christian CouderMar 28, 2007
  7. Junio C HamanoMar 28, 2007
  8. Christian CouderMar 28, 2007
  9. Junio C HamanoMar 28, 2007
  10. Christian CouderMar 29, 2007
  11. Junio C HamanoMar 29, 2007
  12. Christian CouderApr 5, 2007
  13. Christian CouderApr 5, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.