Re: [PATCH] Bisect: add checks at the beginning of "git bisect run".

From: Christian Couder <chriscool@tuxfamily.org>
Date: Mar 29, 2007, 05:02 UTC
Message-ID: <200703290702.47972.chriscool@tuxfamily.org>
In-Reply-To: <7vbqidls13.fsf@assigned-by-dhcp.cox.net>

Le mercredi 28 mars 2007 09:57, Junio C Hamano a écrit :

Show 11 quoted lines

>
> In other words, the above would be equilvalent to
>
>   git bisect start
>   git bisect good nightly_2007_03_27
>   make >/dev/null || {
> 	  git bisect bad
>           git bisect run make >/dev/null
>           # extract commit and author email address from
> "$GIT_DIR/BISECT_RUN" # and send flame to author who broke the build with
> the commit }

Yes, it would be equivalent but a little shorter.

So while we are at it, what about a new subcommand "git bisect test" that could be used like this:

git bisect test good_rev my_script

equivalent to the following :

my_script || {
	git bisect start &&
	git bisect bad &&
	git bisect good good_rev &&
	git bisect run my_script
}

that could be used like this:

git bisect test good_rev my_script || {
	echo >&2 "my_script failed but 'git bisect test' failed too"
	exit 1
}
test -f "$GIT_DIR/BISECT_RUN" && {
	# extract commit and author email address from
	# "$GIT_DIR/BISECT_RUN" and send flames
	git bisect reset
}

Thanks, Christian.