Re: [PATCH v2] git-diff: Output a warning about stale files in the index

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 11, 2007, 20:07 UTC
Message-ID: <7vzm0xltru.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <20070807071712.GA32751@midwinter.com>

Actually this is wrong in two points:

 * The filtering should be done upfront at the beginning of the
   diffcore_std(), not before the end.  Otherwise, unchanged but
   cache dirty file could be subject to copy detection.

 * I do not think it should affect the low-level git-diff-* (or
   you should update the tests, documentations and perhaps
   whatever people can find from google).

By the way, I had an updated version of my patch to fix the first point on 'pu' for a while.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.