git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/3] Rename patch_update_file function to patch_update_pathspec

From
Junio C Hamano <gitster@pobox.com>
Date
Nov 25, 2007, 18:11 UTC
Message-ID
<7vzlx2mc02.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<1195996542-86074-2-git-send-email-win@wincent.com>
Wincent Colaiuta <win@wincent.com> writes:
> The patch_update_file function really works on pathspecs, not files, so
> rename it to reflect its actual purpose.

I do not think this is a correct change. patch_update_file() should work on files not pathspecs.

A list of exact pathnames are valid pathspecs, and because the matching function takes exact match first, if you feed a command (e.g. diff-files) paths expanded from the pathspec given by the user, you should be able to get desired results, no?

patch_update_cmd() grabs list of modified _files_, not pathspecs. Then the user chooses the ones to select hunks from via list_and_choose(), and you may want to pretend that everything was chosen if you are operating with pathspec and with --patch option. Iterating over them is iterating over files, not pathspecs, at that point.

Have you tried the one that is in 'next'? I think it does the right thing except "the bogus pathspec validation at the beginning" part as far as the pathspec handling is concerned.

I sent out two fixes on top of the series.
Previous: Wincent ColaiutaNext: Junio C Hamano
Message 5 of 12 in “Updates to git-add--interactive”
  1. 0/3 Updates to git-add--interactiveWincent Colaiuta, Nov 25, 2007
  2. 1/3 Rename patch_update_file function to patch_update_pathspecWincent Colaiuta, Nov 25, 2007
  3. 2/3 Move pathspec validation into interactive_addWincent Colaiuta, Nov 25, 2007
  4. 3/3 Add "--patch" option to git-add--interactiveWincent Colaiuta, Nov 25, 2007
  5. Junio C HamanoNov 25, 2007
  6. builtin-add: fix command line building to call interactiveJunio C Hamano, Nov 25, 2007
  7. Wincent ColaiutaNov 25, 2007
  8. Junio C HamanoNov 25, 2007
  9. Wincent ColaiutaNov 25, 2007
  10. Junio C HamanoNov 25, 2007
  11. Jeff KingNov 26, 2007
  12. add -i: Fix running from a subdirectoryJunio C Hamano, Nov 25, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.