git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] builtin-add: fix command line building to call interactive

From
Junio C Hamano <gitster@pobox.com>
Date
Nov 25, 2007, 18:36 UTC
Message-ID
<7vlk8mmatu.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<F09249EB-475A-4352-A3A1-A8B15D2A94FF@wincent.com>
Wincent Colaiuta <win@wincent.com> writes:
Show 8 quoted lines
> El 25/11/2007, a las 19:07, Junio C Hamano escribi󺊊> The earlier 7c0ab4458994aa895855abc4a504cf693ecc0cf1 (Teach builtin- 
>> add
>> to pass multiple paths to git-add--interactive) did not allocate  
>> enough,
>
> Yes, it was off by one; sorry about that. You may have noticed that I  
> fixed that up in the patches I sent out yesterday and today. May need  
> to redo them now to apply on top of this.

I'd suggest you to slow down, apply the two patches on top of 'next' and take a look at the result.

I _think_ the only remaining thing is --patch, and none of the pathspec thing is needed.

Previous: Wincent ColaiutaNext: Wincent Colaiuta
Message 8 of 12 in “Updates to git-add--interactive”
  1. 0/3 Updates to git-add--interactiveWincent Colaiuta, Nov 25, 2007
  2. 1/3 Rename patch_update_file function to patch_update_pathspecWincent Colaiuta, Nov 25, 2007
  3. 2/3 Move pathspec validation into interactive_addWincent Colaiuta, Nov 25, 2007
  4. 3/3 Add "--patch" option to git-add--interactiveWincent Colaiuta, Nov 25, 2007
  5. Junio C HamanoNov 25, 2007
  6. builtin-add: fix command line building to call interactiveJunio C Hamano, Nov 25, 2007
  7. Wincent ColaiutaNov 25, 2007
  8. Junio C HamanoNov 25, 2007
  9. Wincent ColaiutaNov 25, 2007
  10. Junio C HamanoNov 25, 2007
  11. Jeff KingNov 26, 2007
  12. add -i: Fix running from a subdirectoryJunio C Hamano, Nov 25, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.