git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/3] Rename patch_update_file function to patch_update_pathspec

From
Wincent Colaiuta <win@wincent.com>
Date
Nov 25, 2007, 13:15 UTC
Message-ID
<1195996542-86074-2-git-send-email-win@wincent.com>
In-Reply-To
<1195996542-86074-1-git-send-email-win@wincent.com>

The patch_update_file function really works on pathspecs, not files, so rename it to reflect its actual purpose.

Signed-off-by: Wincent Colaiuta <win@wincent.com>
---
 git-add--interactive.perl |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/git-add--interactive.perl b/git-add--interactive.perl
index e347216..15b2c9f 100755
--- a/git-add--interactive.perl
+++ b/git-add--interactive.perl
@@ -571,11 +571,11 @@ sub patch_update_cmd {
 				       HEADER => $status_head, },
 				     @mods);
 	for (@them) {
-		patch_update_file($_->{VALUE});
+		patch_update_pathspec($_->{VALUE});
 	}
 }
 
-sub patch_update_file {
+sub patch_update_pathspec {
 	my ($ix, $num);
 	my $path = shift;
 	my ($head, @hunk) = parse_diff($path);
-- 
1.5.3.6.1994.g38001
Previous: Wincent ColaiutaNext: Wincent Colaiuta
Message 2 of 12 in “Updates to git-add--interactive”
  1. 0/3 Updates to git-add--interactiveWincent Colaiuta, Nov 25, 2007
  2. 1/3 Rename patch_update_file function to patch_update_pathspecWincent Colaiuta, Nov 25, 2007
  3. 2/3 Move pathspec validation into interactive_addWincent Colaiuta, Nov 25, 2007
  4. 3/3 Add "--patch" option to git-add--interactiveWincent Colaiuta, Nov 25, 2007
  5. Junio C HamanoNov 25, 2007
  6. builtin-add: fix command line building to call interactiveJunio C Hamano, Nov 25, 2007
  7. Wincent ColaiutaNov 25, 2007
  8. Junio C HamanoNov 25, 2007
  9. Wincent ColaiutaNov 25, 2007
  10. Junio C HamanoNov 25, 2007
  11. Jeff KingNov 26, 2007
  12. add -i: Fix running from a subdirectoryJunio C Hamano, Nov 25, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.