Re: [PATCH] help git-upload-pack find git
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Sep 15, 2008, 19:34 UTC
- Message-ID
- <7vzlm9b3v4.fsf@gitster.siamese.dyndns.org>
- In-Reply-To
- <1221495891-12600-1-git-send-email-git@drmicha.warpmail.net>
Michael J Gruber <git@drmicha.warpmail.net> writes:
Show 5 quoted lines
> The corresponding bug was reported by Paul Johnston who wondered why > "git clone" failed when specifying --upload-pack for an out-of-$PATH > installation of git. I'm not sure whether we should encourage this, but > the --upload-pack option clearly gives the impression that > git-upload-pack is all that is needed.
Another possibility would be to teach exec_cmd.c:setup_path() to add the directory specified by $(bindir) to PATH after we add GIT_EXEC_PATH to it. That should cover the case David Miller reported, shouldn't it?