Re: [PATCH] help git-upload-pack find git

From: Michael J Gruber <git@drmicha.warpmail.net>
Date: Sep 16, 2008, 15:38 UTC
Message-ID: <48CFD30E.7030206@drmicha.warpmail.net>
In-Reply-To: <48CFB81A.5060108@viscovery.net>

Johannes Sixt venit, vidit, dixit 16.09.2008 15:43:

Show 16 quoted lines

> Michael J Gruber schrieb:
>> Why is it that setup_path() cannot be done before commit_pager_choice()?
>> We need the pager in case list_common_cmds_help() is triggered, but why
>> can't setup_path() be before that? Not because of "--", really.
> 
> I think that setup_path() must be called *after* handle_options() because
> of this use-case:
> 
>   $ git --exec-path=/some/where foo
> 
> and git_set_argv0_path() must be called *before* handle_options() because
> of this use-case:
> 
>   $ git --exec-path
> 
> -- Hannes

Tricky, I see. But still I'm getting more and more confused: handle_options() calls git_exec_path() in this case, which does (unless there is argv_exec_path or the variable): return system_path(GIT_EXEC_PATH) Duh, that comes from the Makefile, -DGIT_EXEC_PATH... Back to somewhat less confused state.

OK, now how about

A: path as submitted

or

B: leave git.c as is, except that setup_path(NULL) is used; have
setup_path(argv0path) call git_set_argv0_path() unless the arg is NULL;
tell upload-pack etc. to stuff (other setup_path() callers) their
argv[0] into setup_path(). Junio, is that what you meant?

Michael