Re: [PATCH] help git-upload-pack find git

From: Johannes Sixt <j.sixt@viscovery.net>
Date: Sep 16, 2008, 13:43 UTC
Message-ID: <48CFB81A.5060108@viscovery.net>
In-Reply-To: <48CFB183.1090205@drmicha.warpmail.net>

Michael J Gruber schrieb:

> Why is it that setup_path() cannot be done before commit_pager_choice()?
> We need the pager in case list_common_cmds_help() is triggered, but why
> can't setup_path() be before that? Not because of "--", really.

I think that setup_path() must be called *after* handle_options() because of this use-case:

  $ git --exec-path=/some/where foo

and git_set_argv0_path() must be called *before* handle_options() because of this use-case:

  $ git --exec-path

-- Hannes