Re: [PATCH RFC3.5 04/12] send-email: Verification for --smtp-server and --smpt-server-port

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 20, 2009, 01:42 UTC
Message-ID: <7vzlecnlsh.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <1240074128-16132-5-git-send-email-mfwitten@gmail.com>

Michael Witten <mfwitten@gmail.com> writes:

Show 7 quoted lines

> The server URI is verified according to RFCs (including IPv6 support).
>
> The $smtp_server and $smtp_server_port setup code has been moved
> higher in the file, so that send-email fails fast if they are bad.
>
> Now, the 'host:port' server URI form is handled regardless of the
> documentation deficiencies of Net::SMTP{,::SSL}.

You said that in 01/12, too but I do not think there is any problem with Perl documentation.

My installed copy of /usr/share/perl/5.10.0/Net/SMTP.pm has this:

    B<Host> - SMTP host to connect to. It may be a single scalar, as defined for
    the C<PeerAddr> option in L<IO::Socket::INET>, or a reference to
    an array with hosts to try in turn. The L</host> method will return the value
    which was used to connect to the host.

and of course PeerAddr allows host:port.

Please stop placing a false blame on others. I think it is you who lack ability to read the documentation correctly in this particular case.