Re: [PATCH RFC3.5 06/12] send-email: Cleanup and streamline the SMTP code in send_message

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 20, 2009, 06:43 UTC
Message-ID: <7veivnlt9l.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <b4087cc50904192238j744f353dtf5f6a616cada8cd8@mail.gmail.com>

Michael Witten <mfwitten@gmail.com> writes:

Show 7 quoted lines

> In any case, I also like:
>
>     condition and/or (do something);
>
> or:
>
>     condition and/or do something;

I do not have problem with (condition and/or do this).

What I complained about was statement modifier that interrupts your thought process and forces you to read things twice. You see "DIE", and you have to stop "Huh?". You only realize that the author did not mean to say "always die here" after seeing the modifier that changes the meaning of "die" to "only under this rare condition--sorry, I did not say this upfront, but I am checking for errors."

I just do not want to hear "sorry, I did not say this upfront" part. IOW, I have much less problem with this:

	do this;
	do that;
	condition that usually holds true
        	or die ...
	do some other thing;