Re: [PATCH] contrib: GnomeKeyring support + generic helper implementation
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Aug 24, 2012, 21:46 UTC
- Message-ID
- <7vzk5kx8so.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <20120824213342.GB16285@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
> However, the shared bits are simple enough that maybe that is not a > concern. An interesting test would be to add a 5/4 porting Erik's win32 > credential helper, since that is the platform least like our other ones.
Very true.
> So I am OK with this series, but I am also OK with leaving it at patch > 1, and just keeping the implementations separate.
Amen.