Re: [PATCH] contrib: GnomeKeyring support + generic helper implementation

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 26, 2012, 17:46 UTC
Message-ID: <7vr4qtv94h.fsf@alter.siamese.dyndns.org>
In-Reply-To: <7vzk5kx8so.fsf@alter.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com> writes:

Show 12 quoted lines

> Jeff King <peff@peff.net> writes:
>
>> However, the shared bits are simple enough that maybe that is not a
>> concern. An interesting test would be to add a 5/4 porting Erik's win32
>> credential helper, since that is the platform least like our other ones.
>
> Very true.
>
>> So I am OK with this series, but I am also OK with leaving it at patch
>> 1, and just keeping the implementations separate.
>
> Amen.

Just to make sure we do not leave loose ends, could somebody try to see if the new "generic helper" infrastructure is useful to shrink Erik's win32 credential helper implementation?

If we see much code reduction and improved clarity, this refactoring may worth keeping. Otherwise it may be sufficient to drop the later ones in the series. Without knowing which, it is hard to decide.

Thanks.