Re: [PATCH 5/4] wincred: port to generic credential helper (UNTESTED)

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 30, 2012, 20:11 UTC
Message-ID: <7vpq68qgwx.fsf@alter.siamese.dyndns.org>
In-Reply-To: <CABPQNSZsXnf2kjcN+Qma8pApjGRF6SD5iJjB2Ow6GuGts0Z=Kg@mail.gmail.com>

Erik Faye-Lund <kusmabite@gmail.com> writes:

Show 22 quoted lines

> On Mon, Aug 27, 2012 at 12:04 AM, Philipp A. Hartmann <pah@qo.cx> wrote:
>> From: "Philipp A. Hartmann" <pah@qo.cx>
>>
>> This patch is an experiment to port the wincred helper
>> to the generic implementation.  As of know, it is
>> completely untested.
>>
>> In addition to porting the helper to the generic API,
>> this patch clears up all passwords from memory, which
>> reduces the total amount to saved lines.
>>
>> Signed-off-by: Philipp A. Hartmann <pah@qo.cx>
>> ---
>>
>> The porting was fairly easy, but due to the lack of a testing
>> platform, it is completely untested.
>>
>> Erik: Can you try to have look?
>
> Sorry for the late reply, I'm currently in bed with pneumonia.
>
> But I gave it a quick go, but as-is it's a NACK; a wall of warnings and errors.

Thanks, and get well soon.

For now, let's not worry about merging the "let's share code across helpers" bit that comes later in Philipp's series.