Re: [RFC] prune: --expire=seconds

From: Junio C Hamano <junkio@cox.net>
Date: Jan 18, 2007, 22:32 UTC
Message-ID: <7vy7o0klt1.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <20070118222919.GA22060@moooo.ath.cx>

Matthias Lederhofer <matled@gmx.net> writes:

Show 14 quoted lines

> This option specifies the minimum age of an object before it
> may be removed by prune.  The default value is 2 hours and
> may be changed using gc.pruneexpire.
>
> Signed-off-by: Matthias Lederhofer <matled@gmx.net>
> ---
> Shawn O. Pearce <spearce@spearce.org> wrote:
>> If you are going to implement this I would suggest making the default
>> age 2 hours and allow the user to configure it from a gc.pruneexpire
>> configuration option, much like gc.reflogexpire.
>
> Here it is, I've set the default value to 2 hours as you suggested.
> Any other comments if the default should be a value >0 or 0 to keep
> the old behaviour?

I am not sure if this is needed, as Shawn explained earlier rounds of loose-objects safety work.

If this is something we would want, it might make sense if we allowed "prune --expire='1.day'" syntax ;-).